Skip to content

Fix incorrect waker update condition #7656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Jun 27, 2025
Merged

Fix incorrect waker update condition #7656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beacon_node/lighthouse_network/src/rpc/handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ where
ConnectionHandlerEvent<Self::OutboundProtocol, Self::OutboundOpenInfo, Self::ToBehaviour>,
> {
if let Some(waker) = &self.waker {
if waker.will_wake(cx.waker()) {
if !waker.will_wake(cx.waker()) {
self.waker = Some(cx.waker().clone());
}
} else {
Expand Down
2 changes: 1 addition & 1 deletion beacon_node/network/src/subnet_service/attestation_subnets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ impl<T: BeaconChainTypes> Stream for AttestationService<T> {
fn poll_next(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> {
// Update the waker if needed.
if let Some(waker) = &self.waker {
if waker.will_wake(cx.waker()) {
if !waker.will_wake(cx.waker()) {
self.waker = Some(cx.waker().clone());
}
} else {
Expand Down
2 changes: 1 addition & 1 deletion beacon_node/network/src/subnet_service/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ impl<T: BeaconChainTypes> Stream for SubnetService<T> {
fn poll_next(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> {
// Update the waker if needed.
if let Some(waker) = &self.waker {
if waker.will_wake(cx.waker()) {
if !waker.will_wake(cx.waker()) {
self.waker = Some(cx.waker().clone());
}
} else {
Expand Down
2 changes: 1 addition & 1 deletion beacon_node/network/src/subnet_service/sync_subnets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ impl<T: BeaconChainTypes> Stream for SyncCommitteeService<T> {
fn poll_next(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> {
// update the waker if needed
if let Some(waker) = &self.waker {
if waker.will_wake(cx.waker()) {
if !waker.will_wake(cx.waker()) {
self.waker = Some(cx.waker().clone());
}
} else {
Expand Down
Loading