Skip to content

Rust clippy 1.87 lint fixes#7471

Merged
mergify[bot] merged 1 commit into
sigp:unstablefrom
eserilev:rust-clippy-1.87
May 16, 2025
Merged

Rust clippy 1.87 lint fixes#7471
mergify[bot] merged 1 commit into
sigp:unstablefrom
eserilev:rust-clippy-1.87

Conversation

@eserilev
Copy link
Copy Markdown
Member

@eserilev eserilev commented May 16, 2025

Issue Addressed

Fix clippy lints for rustc 1.87

Proposed Changes

clippy complains about BeaconChainError being too large. I went on a bit of a boxing spree because of this. We may instead want to Box some of the BeaconChainError variants?

@eserilev eserilev requested a review from jxs as a code owner May 16, 2025 02:43
@eserilev eserilev added ready-for-review The code is ready for review code-quality labels May 16, 2025
michaelsproul
michaelsproul approved these changes May 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a bit cleaner to box inside BeaconChainError, but in the interests of unblocking CI I'm happy to merge this and revisit it later.

@michaelsproul
Copy link
Copy Markdown
Member

michaelsproul commented May 16, 2025

At a glance none of the BeaconChainError variants look bloated to me, so I'm curious which one it is.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

Some required checks have failed. Could you please take a look @eserilev? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels May 16, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify mergify Bot added ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review labels May 16, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify mergify Bot added ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review labels May 16, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify mergify Bot added ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review labels May 16, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify mergify Bot added ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review labels May 16, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify mergify Bot added ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review labels May 16, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify mergify Bot added ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review labels May 16, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify mergify Bot added the ready-for-review The code is ready for review label May 16, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

15 similar comments
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@eserilev eserilev mentioned this pull request May 16, 2025
Open
@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees

No one assigned

Labels

code-quality ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eserilev @michaelsproul