Move work queue structs and initialization logic to a separate file and a small refactor #7438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
changed the title
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
the
waiting-on-author
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
…v/lighthouse into move-work-queue-logic
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
ready-for-review
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
mergify
bot
removed
the
waiting-on-author
michaelsproul
added
the
beacon-processor
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
mergify
bot
added
ready-for-review
|
Hi @eserilev, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time. |
mergify
bot
added
the
stale
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially #6291
Proposed Changes
Move work queue structs and init logic to a separate file. Also introduce a few helper functions and refactor the beacon processor slightly. This is purely a cosmetic change and is needed as a second step towards generalizing the beacon processor.
Note that changes from #7437 are included in this PR. Once thats merged the diff in this PR should decrease a bit.
The actual diff can be found here. Im hoping that since this is mostly a copy paste job, that the diff wont be too difficult to review. Happy to break this up further if needed, just let me know!