Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix descent from split check #7105

Merged

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Fix an issue on Holesky after true finalization was reached, whereby blocks on the canonical chain were rejected due to "not descending from the split block".

I think the issue here is that is_descendant will return false for any ancestor_root that has been pruned. Once we got true finality back fork choice got pruned before the split block was updated on some/most nodes, so they hit this error case.

Proposed Changes

Only do the is_descent check if the split.slot is greater than the finalized_slot, or equivalently, set is_descendant_from_split_block when split.slot <= finalized_slot.

@michaelsproul michaelsproul added bug Something isn't working ready-for-review The code is ready for review labels Mar 10, 2025
@michaelsproul michaelsproul merged commit 3645d57 into sigp:holesky-rescue Mar 11, 2025
28 of 29 checks passed
michaelsproul added a commit to eserilev/lighthouse that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant