Skip to content

Conversation

@pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

2 changes:

  1. Replace Option::map_or(true, ...) with is_none_or(...)
  2. Remove unnecessary Into::into blocks where the type conversion is apparent from the types

@pawanjay176 pawanjay176 requested a review from jxs as a code owner February 20, 2025 19:50
@michaelsproul
Copy link
Member

Can you rebase this on release-v7.0.0 and we'll merge it there, and then to unstable?

@pawanjay176 pawanjay176 changed the base branch from unstable to release-v7.0.0 February 21, 2025 00:43
@chong-he chong-he added the ready-for-review The code is ready for review label Feb 21, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 21, 2025
@mergify
Copy link

mergify bot commented Feb 21, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@michaelsproul michaelsproul added the v7.0.0 New release c. Q1 2025 label Feb 23, 2025
@mergify
Copy link

mergify bot commented Feb 24, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify
Copy link

mergify bot commented Feb 24, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #7019 has been manually updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify
Copy link

mergify bot commented Feb 24, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #7019 has been manually updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit b3b6aea into sigp:release-v7.0.0 Feb 24, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge. v7.0.0 New release c. Q1 2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants