Skip to content

Underflow and Typo #6885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Jan 30, 2025
Merged

Underflow and Typo #6885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b24c23
Potential underflow and typo
AgeManning Jan 30, 2025
5b61b05
Update beacon_node/network/src/sync/range_sync/chain_collection.rs
michaelsproul Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions beacon_node/network/src/sync/peer_sync_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ pub fn remote_sync_type<T: BeaconChainTypes>(
) -> PeerSyncType {
// auxiliary variables for clarity: Inclusive boundaries of the range in which we consider a peer's
// head "near" ours.
let near_range_start = local.head_slot - SLOT_IMPORT_TOLERANCE as u64;
let near_range_end = local.head_slot + SLOT_IMPORT_TOLERANCE as u64;
let near_range_start = local.head_slot.saturating_sub(SLOT_IMPORT_TOLERANCE);
let near_range_end = local.head_slot.saturating_add(SLOT_IMPORT_TOLERANCE);

match remote.finalized_epoch.cmp(&local.finalized_epoch) {
Ordering::Less => {
Expand Down
2 changes: 1 addition & 1 deletion beacon_node/network/src/sync/range_sync/chain_collection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ impl<T: BeaconChainTypes> ChainCollection<T> {
RangeSyncState::Head(syncing_head_ids)
};
} else {
// we removed a head chain, or an stoped finalized chain
// we removed a head chain, or a stopped finalized chain
debug_assert!(!was_syncing || sync_type != RangeSyncType::Finalized);
}
}
Expand Down