Skip to content

Comments

Update metrics.rs#6863

Merged
mergify[bot] merged 1 commit intosigp:unstablefrom
kamuik16:kamui/5206
Feb 6, 2025
Merged

Update metrics.rs#6863
mergify[bot] merged 1 commit intosigp:unstablefrom
kamuik16:kamui/5206

Conversation

@kamuik16
Copy link
Contributor

Issue Addressed

Fixes #5206, a low-hanging fruit.

@kamuik16
Copy link
Contributor Author

There was already a PR #5215 for it, but it was closed, I don't know why.

@chong-he chong-he added the ready-for-review The code is ready for review label Jan 27, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A range of 10-150ms seems good to me. Thanks

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 6, 2025
mergify bot added a commit that referenced this pull request Feb 6, 2025
@mergify mergify bot merged commit a4e3f36 into sigp:unstable Feb 6, 2025
31 checks passed
@kamuik16 kamuik16 deleted the kamui/5206 branch February 6, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants