Electra minor refactorings#6839
Merged
mergify[bot] merged 4 commits intosigp:unstablefrom Jan 23, 2025
Merged
Conversation
michaelsproul
added
ready-for-review
michaelsproul
approved these changes
Jan 23, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Looks good! Thanks Pawan for implementing, and Justin for reviewing!
michaelsproul
added
ready-for-merge
Member
|
Testing the new Mergify integration. Let's see if this merges automatically |
Member
|
Ok.. so Mergify isn't picking this up. |
Member
|
@mergify refresh |
✅ Pull request refreshed |
Member
|
@mergify queue |
Member
|
We'll do it the old-fashioned way for now |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 266b241 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Fix some typos and other minor refactorings in the electra code. Thanks @jtraglia for bringing them up.
Note to reviewiers: 4780349 is the commit that needs looking into in detail. The rest are very minor refactorings