Add MetaData V3 support to node/identity API#6827
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom Jan 22, 2025
Merged
Conversation
jimmygchen
force-pushed
the
metadata-v3-http
branch
from
3833ff8 to
d0943ab
Compare
jimmygchen
added a commit
that referenced
this pull request
Jan 21, 2025
Squashed commit of the following: commit d0943ab Author: Jimmy Chen <jchen.tc@gmail.com> Date: Tue Jan 21 16:26:54 2025 +1100 Add metadata v3 support to `node/identity` api.
michaelsproul
approved these changes
Jan 22, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM, this probably needs a corresponding PR on beacon-apis?
michaelsproul
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 2b6ec96 |
This was referenced Jan 22, 2025
Member
Author
Thanks, I'll work on one this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses #6348 - add
custody_group_counttonode/identityresponse, if Fulu/PeerDA fork is scheduled, otherwise maintain the same behaviour (MetaDataV2response).