Misc. dependency cleanup

[dknopik]

Issue Addressed

Anchor depends on some parts of Lighthouse. Due to certain dependencies between crates, it pulled in far more crates than necessary, causing longer builds.

Proposed Changes

remove ensure_dir_exists: account_utils and validator_dir used the directory crate for a single function: ensure_dir_exists. This function had questionable value, as create_dir_all is a no-op if the directory exists anyway. Remove ensure_dir_exists and the two dependencies on directory, which is potentially expensive to depend on due to its dependency on clap_utils.

group UNHANDLED_ERRORs into a generic: warp_utils depends on beacon_chain to provide beacon_chain_error. This causes validator_client to depend on beacon_chain transitively, which is not nice.
Remove beacon_chain_error and similar functions and provide a generic unhandled_error instead, which behaves exactly the same.

Introduce separate health_metrics crate by Sayan: The warp_utils crate contained facilities for capturing health metrics. Anchor wants those metrics, but also wants to avoid pulling in warp, as we are axum-only, so we introduce a new crate called health_metrics. We use the opportunity to also move the logic for capturing this data from eth2 to that new crate.

Additional Info

Lighthouse also benefits from this, as the build can run more parallelized.

[AgeManning]

Does anchor depend on warp_utils? In principle we don't want anything to do with warp, but maybe there's stuff in there we needed?

[AgeManning]

Looks like an improvement to me

[AgeManning]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 669932a

[dknopik]

Does anchor depend on warp_utils? In principle we don't want anything to do with warp, but maybe there's stuff in there we needed?

Not any more after the health_metrics crate was introduced.