Remove ineffectual block RPC limits post merge#6798
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom Jan 15, 2025
Merged
Remove ineffectual block RPC limits post merge#6798mergify[bot] merged 2 commits intosigp:unstablefrom
mergify[bot] merged 2 commits intosigp:unstablefrom
Conversation
jimmygchen
reviewed
Jan 15, 2025
jimmygchen
reviewed
Jan 15, 2025
jimmygchen
reviewed
Jan 15, 2025
jimmygchen
requested changes
Jan 15, 2025
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Yay to removing more code \o/
I think there are a few more things we can remove. Please see comments.
jimmygchen
added
waiting-on-author
dapplion
added
ready-for-review
jimmygchen
approved these changes
Jan 15, 2025
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Looks great, thanks! -300 lines 🔪
jimmygchen
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at b1a19a8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
After the merge the max SSZ size of a block is absurdly big. The size is actually bound by other constants, so computing the fork's actual max size is pointless.
We can get rid of more fork boilerplate.
Close #6790
Proposed Changes
Use bellatrix's max value in block's rpc_block_limits_by_fork for post-merge forks