Conversation
|
|
||
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| if s.as_bytes().len() > GRAFFITI_BYTES_LEN { | ||
| if s.len() > GRAFFITI_BYTES_LEN { |
Member
There was a problem hiding this comment.
This one is interesting. String length is in bytes, so makes sense:
Member
Author
There was a problem hiding this comment.
Yeah i was confused as well, but the lint explicitly stated that they are equivalent
Member
|
Going to try merging this in the same batch as: |
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 1f6850f |
This was referenced Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Fix all lints from rust 1.84.
.map_or(false..tois_ok_and../is_some_and..unnecessay_map_or&strreturns the number of bytes anyway so we were using as_bytes() unnecesssarily needless_as_bytes