Conversation
|
Tests seem to be failing, gonna try and fix it tomorrow |
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Looks good and the tests are passing, so we're good to go.
michaelsproul
added
ready-for-merge
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyDetailsThe followup |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyDetailsThe followup |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyDetailsThe followup |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The pull request #6685 has been manually updated. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 2662dc7 |
2 participants
Issue Addressed
N/A
Proposed Changes
The
get_eventsapi inBeaconNodeHttpClientuses a regular http get request to stream the events. This doesn't handle a lot of sse params like return of partial bytes, maintaining a heartbeat etc. Using the get_events stream as an api consumer led to the connection getting repeatedly cutoff.This PR uses reqwest_eventsource to do the sse handling.
Additional Info
Using reqwest-eventsource v0.5 to keep the reqwest version same as what we use in lighthouse.