Prevent reconstruction starting prematurely

[michaelsproul]

Issue Addressed

Fix a long-standing issue most recently reported by @xrchz whereby Lighthouse attempts to start state reconstruction too early.

Dec 02 07:11:49.453 ERRO State reconstruction failed error: MissingHistoricBlocks { oldest_block_slot: Slot(543328) }, service: beacon

Proposed Changes

When starting up, only attempt to start state reconstruction if block backfill is already complete. A similar guard condition already exists at the point in block backfill where we start reconstruction:

lighthouse/beacon_node/beacon_chain/src/historical_blocks.rs

Lines 279 to 284 in c042dc1

	if backfill_complete
	&& self.genesis_backfill_slot == Slot::new(0)
	&& self.config.reconstruct_historic_states
	{
	self.store_migrator.process_reconstruction();
	}

Additional Info

Alternatively we could refactor the reconstruction code itself to just log a debug message and return Ok(()) in the case where reconstruction is not yet ready to start. However due to the limited number of places from which reconstruction can be triggered, I think the current approach is preferable, as it avoids sending and processing an unnecessary event.

[jimmygchen]

Looks good, thanks!

[michaelsproul]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at fc0e0ae