Add test to beacon node fallback feature #6568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
jimmygchen
force-pushed
the
vc-fallback-test
branch
from
c12bd4c to
eb92dd5
Compare
jimmygchen
added
ready-for-review
…ouse into vc-fallback-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to beacon node fallback using mockito crate: https://crates.io/crates/mockito to create mock beacon nodes. The tests include:
update_all_candidatesfunction inupdate_all_candidates_should_update_sync_statusbroadcastfunction inbroadcast_should_send_to_all_bnsfirst_successfunction infirst_success_should_try_nodes_in_orderA majority part of the code was written by @jimmygchen, thank you Jimmy for the help and guidance, I learn a lot along the way.