Revise Siren documentation#6553
Merged
mergify[bot] merged 21 commits intosigp:unstablefrom Dec 19, 2024
Merged
Conversation
chong-he
commented
Oct 31, 2024
antondlr
reviewed
Oct 31, 2024
Member
antondlr
left a comment
antondlr
left a comment
There was a problem hiding this comment.
if you can wait a couple days, I can make suggestion commits for the items I stipulated (https instead of ssh).
and/or if you're confused we can have a call to discuss it, so I can explain.
chong-he
added
waiting-on-author
chong-he
added
ready-for-review
chong-he
added
waiting-on-author
Member
Author
|
As discussed with @antondlr, waiting for some testing and a final check before this is complete |
Member
|
Almost ready to merge this one? |
Member
Author
Got some tests and final checking pending, will try to get it done soon |
chong-he
added
ready-for-review
antondlr
approved these changes
Dec 17, 2024
Member
antondlr
left a comment
antondlr
left a comment
There was a problem hiding this comment.
let's go!!
there's some stuff that will need rephrasing after magick93's pr gets merged but let's leave that out of scope for now
chong-he
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 5022398 |
This was referenced Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update Siren documentation in Lighthouse book. There are quite some changes compared to the original doc so I will leave some comments to sections to highlight the change. I have also combined
ConfigurationandInstallationtogether as they are quite related to start Siren.