Add 'beacon_' prefix to PeerDAS metrics names #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
reviewed
Nov 5, 2024
| @@ -1812,7 +1812,7 @@ pub static KZG_VERIFICATION_BATCH_TIMES: LazyLock<Result<Histogram>> = LazyLock: | |||
| pub static KZG_VERIFICATION_DATA_COLUMN_SINGLE_TIMES: LazyLock<Result<Histogram>> = | |||
| LazyLock::new(|| { | |||
| try_create_histogram_with_buckets( | |||
| "kzg_verification_data_column_single_seconds", | |||
| "beacon_kzg_verification_data_column_single_seconds", | |||
| "Runtime of single data column kzg verification", | |||
There was a problem hiding this comment.
Note that we also have similar metrics (e.g. kzg_verification_single_seconds) for Deneb blobs, but we can probably leave them as it is, as they will eventually be replaced by the PeerDAS ones.
jimmygchen
reviewed
Nov 5, 2024
| "Time taken to reconstruct columns", | ||
| ) | ||
| }); | ||
| pub static DATA_AVAILABILITY_RECONSTRUCTED_COLUMNS: LazyLock<Result<IntCounter>> = | ||
| LazyLock::new(|| { | ||
| try_create_int_counter( | ||
| "data_availability_reconstructed_columns_total", | ||
| "beacon_data_availability_reconstructed_columns_total", | ||
| "Total count of reconstructed columns", | ||
| ) | ||
| }); |
There was a problem hiding this comment.
Could you also update the 4 data column metrics below to include the prefix too?
There was a problem hiding this comment.
Found 3 kzg_data_column metrics below. What about data_availability_cache_size metrics above?
jimmygchen
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Thanks @KatyaRyazantseva, the prefix make sense, just one minor comment here to update a few other related metrics.
jimmygchen
added
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This PR addresses issue #6018, the list of the PeerDAS metrics.
Proposed Changes
Added
beacon_prefix to metrics names to align with PeerDAS metrics specs.