Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some PeerDAS todos #6434

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Resolve some PeerDAS todos #6434

wants to merge 1 commit into from

Conversation

dapplion
Copy link
Collaborator

Issue Addressed

Clean-up some stale TODO(das) tags

Proposed Changes

Explained inlined in code

@dapplion dapplion added ready-for-review The code is ready for review das Data Availability Sampling labels Sep 25, 2024
@dapplion dapplion force-pushed the resolve-sampling-todos branch 2 times, most recently from 55e8f5a to f6832de Compare September 27, 2024 16:48
jimmygchen
jimmygchen approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old comments clean ups look good to me!

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 14, 2024
@jimmygchen
Copy link
Member

@dapplion There are conflicts to fix before merging.

@dapplion dapplion added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
das Data Availability Sampling ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dapplion @jimmygchen