Avoid redundant allocations in blob verification #6282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
kevaundray
approved these changes
Aug 20, 2024
realbigsean
approved these changes
Aug 20, 2024
Member
|
@mergify queue |
realbigsean
added
ready-for-merge
🛑 The pull request has been removed from the queue
|
5 tasks
Member
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 56d1c8c |
5 tasks
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
* Avoid redundant allocations in blob verification
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Avoid redundant allocations in blob verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Micro-optimisations to allocate 1 vec instead of 2 during KZG blob verification, and removal of an unnecessary
clone.Additional Info
I haven't benchmarked this optimisation but I think it's low-risk and pretty much a no-brainer