Make portable the default in Lighthouse book and Makefile, update workflows
#6247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chong-he
commented
Aug 9, 2024
chong-he
added
ready-for-review
jimmygchen
reviewed
Aug 9, 2024
jimmygchen
requested changes
Aug 9, 2024
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Looks good to me, just added a small comment.
Be good to get a second review from @michaelsproul or @antondlr .
antondlr
approved these changes
Aug 9, 2024
Member
antondlr
left a comment
antondlr
left a comment
There was a problem hiding this comment.
nice, looking good!
now that we're at it I would prefer to remove the -dev tag, too.
no more confusing double tags for any image!
michaelsproul
approved these changes
Aug 13, 2024
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM
Agree we should also get rid of -dev
jimmygchen
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b6d15bc |
This was referenced Aug 19, 2024
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
…orkflows (sigp#6247) * Remove portable in book * Add back modern in docker.md * Update Makefile * Update release.yml * Update docker.yml * Update book * Minor revision * delete portable tarballs * delete portable in Make command * Fix link in book * mdlint * Remove modernity in docker * Merge branch 'unstable' into update-book-portable * Merge branch 'unstable' into update-book-portable * Remove `-dev` docker images * Merge remote-tracking branch 'origin/unstable' into update-book-portable
chong-he
added a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
…orkflows (sigp#6247) * Remove portable in book * Add back modern in docker.md * Update Makefile * Update release.yml * Update docker.yml * Update book * Minor revision * delete portable tarballs * delete portable in Make command * Fix link in book * mdlint * Remove modernity in docker * Merge branch 'unstable' into update-book-portable * Merge branch 'unstable' into update-book-portable * Remove `-dev` docker images * Merge remote-tracking branch 'origin/unstable' into update-book-portable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
portableis now the default build, this PR:portablethe default where necessaryportableas the default buildportabletag inrelease.ymlmoderntag indocker.yml