Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 1.80.0 lints #6183

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Rust 1.80.0 lints #6183

merged 1 commit into from
Jul 25, 2024

Conversation

macladson
Copy link
Member

Issue Addressed

Fixes the linting errors introduced by Rust 1.80.0
Included:

  • Doc-string indentation
  • Unnecessary borrows
  • Unknown cfgs

macladson
macladson commented Jul 25, 2024
View reviewed changes
beacon_node/lighthouse_network/gossipsub/Cargo.toml
@@ -11,6 +11,7 @@ categories = ["network-programming", "asynchronous"]

[features]
wasm-bindgen = ["getrandom/js"]
rsa = []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if this feature is ever supposed to be used, but adding it like this fixes the lint

@macladson macladson added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Jul 25, 2024
jxs
jxs approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing this Mac! LGTM

@jxs
Copy link
Member

jxs commented Jul 25, 2024

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Jul 25, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at cc55e61

@mergify mergify bot merged commit cc55e61 into sigp:unstable Jul 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macladson @jxs