Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable slasher default features #6115

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

SamWilsn
Copy link
Contributor

Issue Addressed

Because slasher had lmdb as a default feature, it was impossible to have a pure mdbx build of lighthouse.

Proposed Changes

This commit sets default-features = false for slasher so lighthouse can actually choose one or the other.

Because slasher had lmdb as a default feature, it was impossible to have
a pure mdbx build of lighthouse. This commit sets
`default-features = false` for slasher so lighthouse can actually choose
one or the other.
@chong-he chong-he added the ready-for-review The code is ready for review label Jul 17, 2024
@michaelsproul
Copy link
Member

The use case here is that you want to build Lighthouse with cargo build --release --no-default-features and have that exclude LMDB, right? You don't mind building with the extra --no-default-features flag?

@SamWilsn
Copy link
Contributor Author

The use case here is that you want to build Lighthouse with cargo build --release --no-default-features and have that exclude LMDB, right?

No particular use case in mind. Just seemed odd that the lighthouse crate had a slasher-lmdb feature that, when disabled, didn't actually disable the lmdb feature in the slasher crate.

You don't mind building with the extra --no-default-features flag?

This is part of my "packaging Lighthouse for Gentoo" saga. In Gentoo, the default for Rust crates is to compile with --no-default-features and have USE flags that map to the features of the crate.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes! and removed ready-for-review The code is ready for review labels Jul 18, 2024
@michaelsproul
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jul 18, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 86cb3f4

mergify bot added a commit that referenced this pull request Jul 18, 2024
@mergify mergify bot merged commit 86cb3f4 into sigp:unstable Jul 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants