Remove timeout locks

[dapplion]

Issue Addressed

Chatting with @michaelsproul he noted that locks with timeouts can kill liveness, and do more harm than good. If an operation takes more than the timeout to acquire the lock, erroring causes that operation to be retried and fail again.

I recall that timeouts helped in the past with deadlocks. Looks like this thread is well mitigated now?

Proposed Changes

Replace these three timeout rw locks with rw locks

pub const ATTESTATION_CACHE_LOCK_TIMEOUT: Duration = Duration::from_secs(1);
pub const VALIDATOR_PUBKEY_CACHE_LOCK_TIMEOUT: Duration = Duration::from_secs(1);
pub const ETH1_FINALIZATION_CACHE_LOCK_TIMEOUT: Duration = Duration::from_millis(200);

[michaelsproul]

We should also hide and deprecate the disable-lock-timeouts flag when removing these

I was going to block the removal of the timeouts on adding deadlock detection, but it seems like getting lockbud to run could be quite involved:

https://github.com/BurtonQin/lockbud

It depends on Rust Nightly, so it will need to be continually updated as we increase our MSRV, and might break in surprising ways (my experience with writing lints pinned to nightly)

[michaelsproul]

@dapplion a few CI failures to fix

[michaelsproul]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b949db0