Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electra attestations #5712 review #5940

Merged
merged 30 commits into from
Jun 19, 2024
Merged

Electra attestations #5712 review #5940

merged 30 commits into from
Jun 19, 2024
+533 −781

Commits on Jun 19, 2024

  1. De-dup attestation constructor logic

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    d87541c View commit details
    Browse the repository at this point in the history

  2. Remove unwraps in Attestation construction

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    dd0d5e2 View commit details
    Browse the repository at this point in the history

  3. Dedup match_attestation_data

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3ec21a2 View commit details
    Browse the repository at this point in the history

  4. Remove outdated TODO

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    795eff9 View commit details
    Browse the repository at this point in the history

  5. Use ForkName Ord in fork-choice tests

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    960f8c5 View commit details
    Browse the repository at this point in the history

  6. Use ForkName Ord in BeaconBlockBody

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    1d0e3f4 View commit details
    Browse the repository at this point in the history

  7. Make to_electra not fallible

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    5acc052 View commit details
    Browse the repository at this point in the history

  8. Remove TestRandom impl for IndexedAttestation

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4f08f6e View commit details
    Browse the repository at this point in the history

  9. Remove IndexedAttestation faulty Decode impl

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f049285 View commit details
    Browse the repository at this point in the history

  10. Drop TestRandom impl

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    5070ab2 View commit details
    Browse the repository at this point in the history

  11. Add PendingAttestationInElectra

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    45d007a View commit details
    Browse the repository at this point in the history

  12. Indexed att on disk (#35) 

    * indexed att on disk

* fix lints

* Update slasher/src/migrate.rs

Co-authored-by: ethDreamer <37123614+ethDreamer@users.noreply.github.com>

---------

Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com>
Co-authored-by: ethDreamer <37123614+ethDreamer@users.noreply.github.com>
    @realbigsean @dapplion @ethDreamer
    3 people committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    9e84779 View commit details
    Browse the repository at this point in the history

  13. add electra fork enabled fn to ForkName impl (#36) 

    * add electra fork enabled fn to ForkName impl

* remove inadvertent file
    @eserilev @dapplion
    eserilev authored and dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    7af3f2e View commit details
    Browse the repository at this point in the history

  14. Update common/eth2/src/types.rs 

    Co-authored-by: ethDreamer <37123614+ethDreamer@users.noreply.github.com>
    @dapplion @ethDreamer
    dapplion and ethDreamer committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2634a1f View commit details
    Browse the repository at this point in the history

  15. Dedup attestation constructor logic in attester cache

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    dec7cff View commit details
    Browse the repository at this point in the history

  16. Use if let Ok for committee_bits

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    6a4d842 View commit details
    Browse the repository at this point in the history

  17. Dedup Attestation constructor code

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    6f0b784 View commit details
    Browse the repository at this point in the history

  18. Diff reduction in tests

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    444cd62 View commit details
    Browse the repository at this point in the history

  19. Fix beacon_chain tests

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    d264736 View commit details
    Browse the repository at this point in the history

  20. Diff reduction

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    7521f97 View commit details
    Browse the repository at this point in the history

  21. Use Ord for ForkName in pubsub

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4d3edfe View commit details
    Browse the repository at this point in the history

  22. Resolve into_attestation_and_indices todo

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    7fce143 View commit details
    Browse the repository at this point in the history

  23. Remove stale TODO

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4d4c268 View commit details
    Browse the repository at this point in the history

  24. Fix beacon_chain tests

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    370d511 View commit details
    Browse the repository at this point in the history

  25. Test spec invariant

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    cbb7c5d View commit details
    Browse the repository at this point in the history

  26. Use electra_enabled in pubsub

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    70a2d4d View commit details
    Browse the repository at this point in the history

  27. Remove get_indexed_attestation_from_signed_aggregate

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    9e6e76f View commit details
    Browse the repository at this point in the history

  28. Use ok_or instead of if let else

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a8d8989 View commit details
    Browse the repository at this point in the history

  29. committees are sorted

    @dapplion
    dapplion committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    d67270f View commit details
    Browse the repository at this point in the history

  30. remove dup method get_indexed_attestation_from_committees

    @realbigsean
    realbigsean committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3977b92 View commit details
    Browse the repository at this point in the history