-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower tolerance of stale blobs on gossip #5935
Conversation
3380fed
to
200b9f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
beacon_node/network/src/network_beacon_processor/gossip_methods.rs
Outdated
Show resolved
Hide resolved
beacon_node/network/src/network_beacon_processor/gossip_methods.rs
Outdated
Show resolved
Hide resolved
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
🛑 The pull request has been removed from the queue
|
@mergify requeue |
☑️ This pull request is already queued |
@mergify unqueue |
✅ The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at adb3f86 |
Proposed Changes
Some peers are spamming old blobs from prior to finalization on gossip. We don't ban them quickly enough due to the high-tolerance peer penalty. This PR changes the penalty to a low-tolerance one.
From the peers that I spot-checked, all the spam seemed to be coming from Erigon/Caplin peers. I've communicated this to the Caplin devs, so new releases of Caplin shouldn't have this problem and won't suffer from by being banned by Lighthouse.
I've kept the gossipsub behaviour as
Ignore
rather than combining with theReject
block above. We are required toIgnore
these blobs by the spec: https://github.com/ethereum/consensus-specs/blob/dev/specs/deneb/p2p-interface.md#blob-subnets