Rust 1.79 lints #5927
Merged
Rust 1.79 lints #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realbigsean
added
ready-for-review
realbigsean
commented
Jun 13, 2024
| @@ -47,7 +48,7 @@ pub struct UpdateHandler<E: EthSpec> { | |||
| pub blockprint: Option<WatchBlockprintClient>, | |||
| pub config: Config, | |||
| pub slots_per_epoch: u64, | |||
| pub spec: WatchSpec<E>, | |||
| pub _phantom: PhantomData<E>, | |||
There was a problem hiding this comment.
Should this generic just be removed instead?
| @@ -33,6 +33,7 @@ pub struct WatchBlockprint { | |||
| } | |||
|
|
|||
| #[derive(Debug, QueryableByName, diesel::FromSqlRow)] | |||
| #[allow(dead_code)] | |||
| pub struct WatchValidatorBlockprint { | |||
There was a problem hiding this comment.
should this be deleted? i don't see it used but not sure if it's a useful export if anything depends on beacon watch?
|
Also I need to cherry pick #5926 in to get CI to pass, so I'm going to close that PR |
michaelsproul
approved these changes
Jun 13, 2024
michaelsproul
added
ready-for-merge
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a740980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
fixing 1.79 lints including:
u64::MAXinstead ofu64::max_value()orstd::u64::MAX#[allow(dead_code)]to these errorsspec: WatchSpec<E>fromUpdateHandleras this was unused - wasn't sure if this field was intentionally there and should be kept?