Change DB Manager Clap usage to derive#5898
Merged
mergify[bot] merged 8 commits intosigp:unstablefrom Jul 12, 2024
Merged
Conversation
eserilev
changed the title
Closed
Member
|
Noticed that e.g. |
Member
Author
|
nice catch, 897bd8d defines the help flag as global now. this seems to have fixed the issue |
eserilev
force-pushed
the
clap-derive-db-manager
branch
from
1fc5ee1 to
bab2c2e
Compare
dapplion
approved these changes
Jul 3, 2024
Collaborator
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
LGTM! Looking forward to see all CLIs with derive :)
jimmygchen
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at b7b5dd7 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially #5900
This is part of a series of PRs that aims to move the Lighthouse cli to clap derive. This PR moves the db manager crate to clap derive and introduces the ability to include clap derive subcommands within our existing clap builder flag definitions.