Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info about why lookup is in AwaitingDownload #5838

Merged
merged 5 commits into from
May 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'unstable' into awaiting-download-context
  • Loading branch information
realbigsean authored May 24, 2024
commit 1d305baaa0ab15806dba71d289b940a90436caa9
Original file line number Diff line number Diff line change
Expand Up @@ -197,16 +197,9 @@ impl<T: BeaconChainTypes> SingleBlockLookup<T> {
}

let Some(peer_id) = self.use_rand_available_peer() else {
if awaiting_parent {
// Allow lookups awaiting for a parent to have zero peers. If when the parent
// resolve they still have zero peers the lookup will fail gracefully.
R::request_state_mut(self)
.get_state_mut()
.update_awaiting_download_status("no_peers_awaiting_parent");
return Ok(());
} else {
return Err(LookupRequestError::NoPeers);
}
// Allow lookup to not have any peers. In that case do nothing. If the lookup does
// not have peers for some time, it will be dropped.
return Ok(());
};

let request = R::request_state_mut(self);
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.