Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement graffiti management API #4951

Merged
merged 17 commits into from
Dec 7, 2023
Merged

Implement graffiti management API #4951

merged 17 commits into from
Dec 7, 2023

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Nov 27, 2023 •
edited
Loading

Issue Addressed

#4947

Proposed Changes

add standardized graffiti management APIs

ethereum/keymanager-APIs#63

Additional Notes

I made the decision of creating a separate function for set_graffiti instead of using set_validator_definition_fields. I may be missing context here, but I felt set_validator_definition_fields usage to be a bit dangerous here as it technically updates 4 fields (enabled, gas_limit, builder_proposals and graffiti)

@eserilev eserilev marked this pull request as ready for review November 27, 2023 06:52
jimmygchen
jimmygchen requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I've added a few comments / questions, but looks great overall 👍

@jimmygchen jimmygchen added val-client Relates to the validator client binary waiting-on-author The reviewer has suggested changes and awaits thier implementation. HTTP-API labels Nov 28, 2023
@jimmygchen jimmygchen added v4.6.0 ETA Q1 2024 ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Dec 4, 2023
jimmygchen
jimmygchen requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're very close! Just a small comment on making the functions non-async.

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Dec 6, 2023
jimmygchen
jimmygchen approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me! Thanks :)

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Dec 7, 2023
michaelsproul
michaelsproul approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@jimmygchen jimmygchen merged commit 8ba39cb into sigp:unstable Dec 7, 2023
24 checks passed
@jimmygchen jimmygchen mentioned this pull request Dec 7, 2023
Closed
@michaelsproul michaelsproul mentioned this pull request Dec 7, 2023
Closed
@chenrui333 chenrui333 mentioned this pull request Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
HTTP-API ready-for-merge This PR is ready to merge. v4.6.0 ETA Q1 2024 val-client Relates to the validator client binary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eserilev @jimmygchen @michaelsproul