Deneb review common/eth2
#4698
Merged
Deneb review common/eth2
#4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nedBlockContents::blobs_cloned` to return blobs for `BlindedBlockAndBlobSidecars`.
…lock into full block.
jimmygchen
added
ready-for-review
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Related to #4676.
Proposed Changes
SsePayloadAttributesintoSsePayloadAttributesV3SignedBlockContents::try_into_full_block_and_blobsto returnResultinstead ofOptionso an error message can be included during unexpected / error scenarios. Refactored the function a bit to reduce amount of nestedmaps for readability, and improved error handling.SignedBlockContents::blobs_clonedto include blobs for the blinded variant. The original intention to return None was to an attempt to indicate an unexpected scenario, but I've realized this pattern is quite misleading, and can lead to some hard to find bugs and misuse of the function. We're better off doing the assertions / checks outside of these functions.