Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve single block/blob logging #4579

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Improve single block/blob logging #4579

merged 6 commits into from
Aug 8, 2023

Conversation

realbigsean
Copy link
Member

No description provided.

@realbigsean realbigsean added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! deneb labels Aug 8, 2023
pawanjay176
pawanjay176 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the whole. Just some cosmetic nits

beacon_node/network/src/sync/network_context.rs Show resolved Hide resolved
beacon_node/network/src/sync/block_lookups/single_block_lookup.rs Show resolved Hide resolved
beacon_node/network/src/sync/block_lookups/mod.rs Outdated Show resolved Hide resolved
beacon_node/network/src/sync/block_lookups/mod.rs Outdated Show resolved Hide resolved
beacon_node/network/src/sync/block_lookups/mod.rs Outdated Show resolved Hide resolved
beacon_node/network/src/sync/block_lookups/mod.rs Outdated Show resolved Hide resolved
beacon_node/network/src/sync/block_lookups/mod.rs Outdated Show resolved Hide resolved
@realbigsean realbigsean merged commit 02c7a2e into sigp:deneb-free-blobs Aug 8, 2023
@realbigsean realbigsean deleted the cleanup branch November 21, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
deneb low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realbigsean @pawanjay176