Skip to content

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Workaround for foundry-rs/foundry#5115.

Proposed Changes

Allow Anvil to be installed on Windows without errors by enabling the IPC features (which we don't use, but Anvil expects to exist).

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! infra-ci labels Jun 7, 2023
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good find!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 7, 2023
@michaelsproul
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 7, 2023
## Issue Addressed

Workaround for foundry-rs/foundry#5115.

## Proposed Changes

Allow Anvil to be installed on Windows without errors by enabling the IPC features (which we don't use, but Anvil expects to exist).
@bors
Copy link

bors bot commented Jun 7, 2023

@bors bors bot changed the title Fix Anvil compilation on Windows [Merged by Bors] - Fix Anvil compilation on Windows Jun 7, 2023
@bors bors bot closed this Jun 7, 2023
@michaelsproul michaelsproul deleted the anvil-windows branch June 7, 2023 04:40
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
## Issue Addressed

Workaround for foundry-rs/foundry#5115.

## Proposed Changes

Allow Anvil to be installed on Windows without errors by enabling the IPC features (which we don't use, but Anvil expects to exist).
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Workaround for foundry-rs/foundry#5115.

## Proposed Changes

Allow Anvil to be installed on Windows without errors by enabling the IPC features (which we don't use, but Anvil expects to exist).
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Workaround for foundry-rs/foundry#5115.

## Proposed Changes

Allow Anvil to be installed on Windows without errors by enabling the IPC features (which we don't use, but Anvil expects to exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants