[Merged by Bors] - Remove CountUnrealized
#4357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
|
@michaelsproul do you want to go ahead with a review without the duplicate check TODO? |
|
I kinda added that todo as I was putting it up, maybe let's wait until I get to it before reviewing. Soz |
michaelsproul
added
work-in-progress
michaelsproul
added
ready-for-review
|
Ready for review now assuming CI passes |
|
Should we also remove the deprecated |
jimmygchen
reviewed
Jun 9, 2023
Usually we wait a few releases with the flags retained as no-ops, so people have some time to remove the flags from their setups. On that topic there are a lot of older deprecated flags lying around that we could safely delete now. |
jimmygchen
approved these changes
Jun 9, 2023
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
paulhauner
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 16, 2023
## Issue Addressed Closes #4332 ## Proposed Changes Remove the `CountUnrealized` type, defaulting unrealized justification to _on_. This fixes the #4332 issue by ensuring that importing the same block to fork choice always results in the same outcome. Finalized sync speed may be slightly impacted by this change, but that is deemed an acceptable trade-off until the optimisation from #4118 is implemented. TODO: - [x] Also check that the block isn't a duplicate before importing
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
CountUnrealizedCountUnrealized
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
## Issue Addressed Closes sigp#4332 ## Proposed Changes Remove the `CountUnrealized` type, defaulting unrealized justification to _on_. This fixes the sigp#4332 issue by ensuring that importing the same block to fork choice always results in the same outcome. Finalized sync speed may be slightly impacted by this change, but that is deemed an acceptable trade-off until the optimisation from sigp#4118 is implemented. TODO: - [x] Also check that the block isn't a duplicate before importing
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
Closes sigp#4332 Remove the `CountUnrealized` type, defaulting unrealized justification to _on_. This fixes the sigp#4332 issue by ensuring that importing the same block to fork choice always results in the same outcome. Finalized sync speed may be slightly impacted by this change, but that is deemed an acceptable trade-off until the optimisation from sigp#4118 is implemented. TODO: - [x] Also check that the block isn't a duplicate before importing
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
Closes sigp#4332 Remove the `CountUnrealized` type, defaulting unrealized justification to _on_. This fixes the sigp#4332 issue by ensuring that importing the same block to fork choice always results in the same outcome. Finalized sync speed may be slightly impacted by this change, but that is deemed an acceptable trade-off until the optimisation from sigp#4118 is implemented. TODO: - [x] Also check that the block isn't a duplicate before importing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #4332
Proposed Changes
Remove the
CountUnrealizedtype, defaulting unrealized justification to on. This fixes the #4332 issue by ensuring that importing the same block to fork choice always results in the same outcome.Finalized sync speed may be slightly impacted by this change, but that is deemed an acceptable trade-off until the optimisation from #4118 is implemented.
TODO: