Skip to content

[Merged by Bors] - Implement liveness BeaconAPI #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Implement liveness BeaconAPI #4343

wants to merge 9 commits into from

Conversation

aoikurokawa
Copy link
Contributor

Issue Addressed

#4243

Proposed Changes

  • create a new endpoint for liveness/{endpoint}

Additional Info

This is my first PR.

@CLAassistant
Copy link

CLAassistant commented May 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

michaelsproul
michaelsproul requested changes May 30, 2023
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

The code is very well-written overall, I just had a few suggestions about how to achieve conformance with the spec.

Thanks!

@michaelsproul michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label May 30, 2023
@aoikurokawa
Copy link
Contributor Author

Thank you for reviewing!.

I think I have fixed all what you reviewed for my code.

@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels May 30, 2023
@paulhauner
Copy link
Member

@aoikurokawa the cargo-fmt check is failing. You can fix this my running cargo fmt in the project root and committing the result ☺️

@aoikurokawa
Copy link
Contributor Author

Oops, sorry.
I run the command cargo fmt, then committed,
I appreciate your review.

jimmygchen
jimmygchen approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

There's just one clippy failure that I think should be fixed by merging latest unstable branch into this branch, and we should be good to merge!

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 19, 2023
@aoikurokawa
Copy link
Contributor Author

aoikurokawa commented Jul 19, 2023 •
edited
Loading

@jimmygchen Thank you for reviewing 🙏
I think I have merged the current unstable branch.

@jimmygchen jimmygchen added HTTP-API ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jul 20, 2023
paulhauner
paulhauner approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat and tidy!

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 20, 2023
@paulhauner paulhauner mentioned this pull request Jul 20, 2023
Closed
@Gua00va Gua00va mentioned this pull request Jul 25, 2023
Closed
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 31, 2023
@aoikurokawa
Implement liveness BeaconAPI (#4343)
85a3340 
## Issue Addressed

#4243

## Proposed Changes

- create a new endpoint for liveness/{endpoint}

## Additional Info
This is my first PR.
@bors
Copy link

bors bot commented Jul 31, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Implement liveness BeaconAPI [Merged by Bors] - Implement liveness BeaconAPI Jul 31, 2023
@bors bors bot closed this Jul 31, 2023
@jimmygchen jimmygchen mentioned this pull request Aug 3, 2023
Closed
@Gua00va Gua00va mentioned this pull request Oct 17, 2023
Merged
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@aoikurokawa @Woodpile37
Implement liveness BeaconAPI (sigp#4343)
d50b538 
## Issue Addressed

sigp#4243

## Proposed Changes

- create a new endpoint for liveness/{endpoint}

## Additional Info
This is my first PR.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@aoikurokawa @Woodpile37
Implement liveness BeaconAPI (sigp#4343)
3bd244f 
- create a new endpoint for liveness/{endpoint}

This is my first PR.
@jshufro jshufro mentioned this pull request Feb 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul requested changes

@jimmygchen jimmygchen jimmygchen approved these changes

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
HTTP-API ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aoikurokawa @CLAassistant @paulhauner @jimmygchen @michaelsproul