Skip to content

[Merged by Bors] - Update discv5 to expand ipv6 support #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - Update discv5 to expand ipv6 support #4319

wants to merge 13 commits into from

Conversation

divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented May 22, 2023 •
edited
Loading

Done in different PRs so that they can reviewed independently, as it's likely this won't be merged before I leave

Includes resolution for #4080

divagant-martian and others added 3 commits May 22, 2023 07:07
@divagant-martian
Update discv5 without the two sockets update (#4299)
2ea5c4d 
* update discv5 version in eth2_network_config

* update discv5 version in lighthouse_network

* update lockfile

* update fn update_enr_udp_socket

* update fn update_enr_tcp_port

* update enr_ext

* update boot_node

* fmt?
@divagant-martian
Update discv5 two sockets (#4318)
2c15b28 
* update discv5 to use two sockets

* directly start discv5 without inspecting the listening address

* update discv5 to use two sockets

* remove trash file

* fmt

* serialize boot listen sockets
@divagant-martian
Make flag visible
0a62daf
AgeManning
AgeManning reviewed May 25, 2023
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I want to just test this against some networks and do a discv5 release before we merge tho. So we have a clean discv5 target.

There was some potentially spicy things in discv5 master at the moment that I want to check still works.

Looking good tho!

@divagant-martian
Copy link
Contributor Author

@AgeManning checking with Pawan the doppelganger tests are failing due to an issue with geth and are not related to these changes. Asking for your review again since I changed some stuff around the boot node flags

AgeManning
AgeManning approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Lets do some testing, a discv5 release and then meeeeeeeerge!

@AgeManning AgeManning added the ready-for-merge This PR is ready to merge. label Jun 13, 2023
@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 13, 2023
@divagant-martian @AgeManning
Update discv5 to expand ipv6 support (#4319)
2639e67 
Done in different PRs so that they can reviewed independently, as it's likely this won't be merged before I leave

Includes resolution for #4080 
- [ ] #4299
- [ ] #4318
- [ ] #4320 

Co-authored-by: Diva M <divma@protonmail.com>
Co-authored-by: Age Manning <Age@AgeManning.com>
@bors
Copy link

bors bot commented Jun 13, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Update discv5 to expand ipv6 support [Merged by Bors] - Update discv5 to expand ipv6 support Jun 13, 2023
@bors bors bot closed this Jun 13, 2023
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
@divagant-martian @AgeManning
Update discv5 to expand ipv6 support (sigp#4319)
bc02548 
Done in different PRs so that they can reviewed independently, as it's likely this won't be merged before I leave

Includes resolution for sigp#4080 
- [ ] sigp#4299
- [ ] sigp#4318
- [ ] sigp#4320 

Co-authored-by: Diva M <divma@protonmail.com>
Co-authored-by: Age Manning <Age@AgeManning.com>
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@divagant-martian @AgeManning @Woodpile37
Update discv5 to expand ipv6 support (sigp#4319)
245334b 
Done in different PRs so that they can reviewed independently, as it's likely this won't be merged before I leave

Includes resolution for sigp#4080
- [ ] sigp#4299
- [ ] sigp#4318
- [ ] sigp#4320

Co-authored-by: Diva M <divma@protonmail.com>
Co-authored-by: Age Manning <Age@AgeManning.com>
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@divagant-martian @AgeManning @Woodpile37
Update discv5 to expand ipv6 support (sigp#4319)
a42ddb5 
Done in different PRs so that they can reviewed independently, as it's likely this won't be merged before I leave

Includes resolution for sigp#4080
- [ ] sigp#4299
- [ ] sigp#4318
- [ ] sigp#4320

Co-authored-by: Diva M <divma@protonmail.com>
Co-authored-by: Age Manning <Age@AgeManning.com>
@AgeManning AgeManning deleted the update-discv5 branch November 25, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
Networking ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divagant-martian @AgeManning