fix check on max request size blobs by range #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realbigsean
added
ready-for-review
pawanjay176
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a check to prevent us from doing work in blobs by range when the request is too long, but ours is currently too low:
if req.count > MAX_REQUEST_BLOB_SIDECARSThis is in the consensus spec:
The response MUST contain no more than count * MAX_BLOBS_PER_BLOCK blob sidecars.So the check should be
if req.count > MAX_REQUEST_BLOB_SIDECARS. Additionally changed the response logging because we can't know whether we've sent all required blobs because the number of blobs requested is not specified in the request