Validator blob signing for the unblinded flow #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realbigsean
reviewed
Mar 16, 2023
| @@ -180,6 +182,10 @@ impl SigningMethod { | |||
| Web3SignerObject::RandaoReveal { epoch } | |||
| } | |||
| SignableMessage::BeaconBlock(block) => Web3SignerObject::beacon_block(block)?, | |||
| SignableMessage::BlobSidecar(_) => { | |||
| // https://github.com/ConsenSys/web3signer/issues/726 | |||
realbigsean
reviewed
Mar 16, 2023
Comment on lines
547
to
556
| // Make sure the blob slot is not higher than the current slot to avoid potential attacks. | ||
| if slot > current_slot { | ||
| warn!( | ||
| self.log, | ||
| "Not signing blob with slot greater than current slot"; | ||
| "blob_slot" => slot.as_u64(), | ||
| "current_slot" => current_slot.as_u64() | ||
| ); | ||
| return Err(Error::GreaterThanCurrentSlot { slot, current_slot }); | ||
| } |
There was a problem hiding this comment.
I think we can remove this because we have the same check for the block and the block and blob slots should be equal or the proposal will be missed. I'm also not sure what the original intent of this check was.
realbigsean
reviewed
Mar 16, 2023
consensus/types/src/chain_spec.rs
Outdated
| @@ -1285,7 +1285,7 @@ mod tests { | |||
|
|
|||
| test_domain(Domain::BeaconProposer, spec.domain_beacon_proposer, &spec); | |||
| test_domain(Domain::BeaconAttester, spec.domain_beacon_attester, &spec); | |||
| test_domain(Domain::BlobsSideCar, spec.domain_blobs_sidecar, &spec); | |||
| test_domain(Domain::BlobSideCar, spec.domain_blob_sidecar, &spec); | |||
There was a problem hiding this comment.
this one's not compiling cause of the capitalization
There was a problem hiding this comment.
Oops, sorry. Fixed now
realbigsean
reviewed
Mar 16, 2023
consensus/types/src/chain_spec.rs
Outdated
| @@ -1311,7 +1311,7 @@ mod tests { | |||
| &spec, | |||
| ); | |||
|
|
|||
| test_domain(Domain::BlobsSideCar, spec.domain_blobs_sidecar, &spec); | |||
| test_domain(Domain::BlobSideCar, spec.domain_blob_sidecar, &spec); | |||
realbigsean
requested changes
Mar 16, 2023
realbigsean
added
the
waiting-on-author
jimmygchen
added
ready-for-review
|
@jimmygchen clippy needs some attention |
Thanks, fixed now! Was having a bit of issue running clippy locally yesterday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses #3994
Proposed Changes
0x0B000000Additional Info