Temporarily allow warnings on CI (4844 branch only) #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
approved these changes
Mar 15, 2023
realbigsean
added a commit
to realbigsean/lighthouse
that referenced
this pull request
Jun 5, 2023
)" This reverts commit fa9baab.
realbigsean
added a commit
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have lots of warnings on things like "unused variables" on the
deneb-free-blobsbranch - these warnings are useful in helping us track missing pieces (e.g. code that we haven't implemented) but this sometimes make it difficult to reveal compilation errors.This PR temporarily allow warnings so we can tackle compilation error first on feature branches. Once we get to a better state, we can reinstate the warnings check.