Skip to content

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Aug 31, 2022

Fixing a few typos in the documentation

omahs added 5 commits August 31, 2022 09:24
Typo
Adding question marks
Typo
Typo
Grammar
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2022

CLA assistant check
All committers have signed the CLA.

@michaelsproul
Copy link
Member

This is the correct way to farm POAPs 😉 (take note @yalexis-eth, author of the previous attempt: #3499)

Before we merge your PR though you need to sign the CLA and change the target branch to unstable. After changing the target branch you also need to amend your commit and re-push it so that Github actions will re-run. i.e. if you want a POAP you've got to work for it ;)

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. docs Documentation labels Aug 31, 2022
@omahs omahs changed the base branch from stable to unstable August 31, 2022 08:28
@omahs
Copy link
Contributor Author

omahs commented Aug 31, 2022

Hi @michaelsproul, thanks for the reply! 😃
I'm actually using the GitHub web interface, I changed the target branch.
I'm not sure how to amend and re-push though, is that possible from the interface?

@michaelsproul
Copy link
Member

You can just make another small change, that should be fine

Copy link
Contributor Author

@omahs omahs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work? 👀

@yalexis-eth
Copy link

This is the correct way to farm POAPs 😉 (take note @yalexis-eth, author of the previous attempt: #3499)

Before we merge your PR though you need to sign the CLA and change the target branch to unstable. After changing the target branch you also need to amend your commit and re-push it so that Github actions will re-run. i.e. if you want a POAP you've got to work for it ;)

My intention are not to farm any POAP, I am new with GitHub itself and I don't know my way around it that much, I am trying to contribute the best ways that I can. I do apologize if I am not doing it correctly.

@divagant-martian
Copy link
Contributor

We have lots of typos all around for all our poap farming contributors and non poap farming contributors like you @yalexis-eth. We encourage you to read our code documentations and give it another try to get your contributions in

@yalexis-eth
Copy link

yalexis-eth commented Aug 31, 2022 via email

@michaelsproul michaelsproul added ready-for-review The code is ready for review v3.1.2 Release after v3.1.0 (formerly v3.1.1) and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 3, 2022
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 5, 2022
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 5, 2022
Fixing a few typos in the documentation
@bors bors bot changed the title Fixing a few typos / documentation [Merged by Bors] - Fixing a few typos / documentation Sep 5, 2022
@bors bors bot closed this Sep 5, 2022
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
Fixing a few typos in the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation ready-for-merge This PR is ready to merge. v3.1.2 Release after v3.1.0 (formerly v3.1.1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants