[Merged by Bors] - Unblock CI by updating git submodules directly in execution integration tests #3479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
changed the title
mastermaster
|
I think we can change our routine to add resilience to these changes by
|
divagant-martian
added
waiting-on-author
whitespace
macladson
force-pushed
the
fix-nethermind-rocksdb
branch
from
15ec011 to
e8e3457
Compare
|
Nice that's a better solution, I've reverted my changes and cherry-picked your commit, thanks! 🙏 |
macladson
changed the title
master
macladson
added
ready-for-review
pawanjay176
approved these changes
Aug 19, 2022
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2022
…on tests (#3479) ## Issue Addressed Recent changes to the Nethermind codebase removed the `rocksdb` git submodule in favour of a `nuget` package. This appears to have broken our ability to build the latest release of Nethermind inside our integration tests. ## Proposed Changes ~Temporarily pin the version used for the Nethermind integration tests to `master`. This ensures we use the packaged version of `rocksdb`. This is only necessary until a new release of Nethermind is available.~ Use `git submodule update --init --recursive` to ensure the required submodules are pulled before building. Co-authored-by: Diva M <divma@protonmail.com>
bors
bot
changed the title
Closed
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
…on tests (sigp#3479) ## Issue Addressed Recent changes to the Nethermind codebase removed the `rocksdb` git submodule in favour of a `nuget` package. This appears to have broken our ability to build the latest release of Nethermind inside our integration tests. ## Proposed Changes ~Temporarily pin the version used for the Nethermind integration tests to `master`. This ensures we use the packaged version of `rocksdb`. This is only necessary until a new release of Nethermind is available.~ Use `git submodule update --init --recursive` to ensure the required submodules are pulled before building. Co-authored-by: Diva M <divma@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Recent changes to the Nethermind codebase removed the
rocksdbgit submodule in favour of anugetpackage.This appears to have broken our ability to build the latest release of Nethermind inside our integration tests.
Proposed Changes
Temporarily pin the version used for the Nethermind integration tests tomaster. This ensures we use the packaged version ofrocksdb. This is only necessary until a new release of Nethermind is available.Use
git submodule update --init --recursiveto ensure the required submodules are pulled before building.