Skip to content

[Merged by Bors] - Restore backwards compatibility when using older BNs #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Restore backwards compatibility when using older BNs #3410

wants to merge 1 commit into from

Conversation

macladson
Copy link
Member

Issue Addressed

status-im/nimbus-eth2#3930

Proposed Changes

We can trivially support beacon nodes which do not provide the is_optimistic field by wrapping the field in an Option.

@macladson macladson added the bellatrix Required to support the Bellatrix Upgrade label Aug 2, 2022
@macladson macladson mentioned this pull request Aug 2, 2022
Closed
@macladson macladson added the ready-for-review The code is ready for review label Aug 2, 2022
paulhauner
paulhauner approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

bors r+

bors bot pushed a commit that referenced this pull request Aug 2, 2022
@macladson
Restore backwards compatibility when using older BNs (#3410)
2562a15 
## Issue Addressed

status-im/nimbus-eth2#3930

## Proposed Changes

We can trivially support beacon nodes which do not provide the `is_optimistic` field by wrapping the field in an `Option`.
@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 2, 2022
@bors
Copy link

bors bot commented Aug 2, 2022

Build failed:

@michaelsproul
Copy link
Member

After discussion with @divagant-martian we think it's safe to temporarily ignore RUSTSEC-2022-01-26 in cargo-audit, as the affected unsound methods are not used.

@paulhauner
Copy link
Member

After discussion with @divagant-martian we think it's safe to temporarily ignore RUSTSEC-2022-01-26 in cargo-audit, as the affected unsound methods are not used.

I think it's RUSTSEC-2022-0040 we want to ignore. I'll make a separate PR now and batch them.

@paulhauner paulhauner mentioned this pull request Aug 2, 2022
Closed
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 2, 2022
@macladson
Restore backwards compatibility when using older BNs (#3410)
e24552d 
## Issue Addressed

status-im/nimbus-eth2#3930

## Proposed Changes

We can trivially support beacon nodes which do not provide the `is_optimistic` field by wrapping the field in an `Option`.
bors bot pushed a commit that referenced this pull request Aug 2, 2022
@paulhauner
Ignore RUSTSEC-2022-0040 - owning_ref soundness (#3415)
553a794 
## Issue Addressed

NA

## Proposed Changes

We are unaffected by this issue: #3410 (comment)

## Additional Info

NA
@bors
Copy link

bors bot commented Aug 3, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Restore backwards compatibility when using older BNs [Merged by Bors] - Restore backwards compatibility when using older BNs Aug 3, 2022
@bors bors bot closed this Aug 3, 2022
@macladson macladson deleted the is_optimisic_fix branch August 3, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
bellatrix Required to support the Bellatrix Upgrade ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macladson @michaelsproul @paulhauner