Skip to content

Conversation

sept-en
Copy link
Contributor

@sept-en sept-en commented Jul 29, 2022

Issue Addressed

#3386

Proposed Changes

  • make blst crate optional
  • include blst dependency into supranational feature
  • hide blst-related code with supranational feature

@sept-en
Copy link
Contributor Author

sept-en commented Jul 29, 2022

I see that test-suite/release-tests-windows test is failing, but I don't think this is related. Perhaps, the workflow just needs to be restarted

@paulhauner paulhauner added the ready-for-review The code is ready for review label Aug 2, 2022
@paulhauner
Copy link
Member

Thanks for the contribution. This looks quite simple, but we're in the middle of a release at the moment and are holding off on merging non-critical PRs until we have release stability.

@sept-en
Copy link
Contributor Author

sept-en commented Aug 2, 2022

Ok, thanks! I hope it will be included in the next release then :)

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 8, 2022
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 8, 2022
## Issue Addressed

#3386 

## Proposed Changes

* make `blst` crate `optional`
* include `blst` dependency into `supranational` feature
* hide `blst`-related code with `supranational` feature

Co-authored-by: Kirill <kirill@aurora.dev>
@bors
Copy link

bors bot commented Aug 8, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 8, 2022
## Issue Addressed

#3386 

## Proposed Changes

* make `blst` crate `optional`
* include `blst` dependency into `supranational` feature
* hide `blst`-related code with `supranational` feature

Co-authored-by: Kirill <kirill@aurora.dev>
@michaelsproul
Copy link
Member

I'm going to fix the batch

bors r-

@bors
Copy link

bors bot commented Aug 8, 2022

Canceled.

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 8, 2022
## Issue Addressed

#3386 

## Proposed Changes

* make `blst` crate `optional`
* include `blst` dependency into `supranational` feature
* hide `blst`-related code with `supranational` feature

Co-authored-by: Kirill <kirill@aurora.dev>
@bors bors bot changed the title crypto/bls: make blst dependency optional [Merged by Bors] - crypto/bls: make blst dependency optional Aug 9, 2022
@bors bors bot closed this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants