Skip to content

[Merged by Bors] - Downgrade Geth to v1.10.20 in EE integration tests #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Downgrade Geth to v1.10.20 in EE integration tests #3382

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c124208
Allow payload to be VALID or ACCEPTED
paulhauner Jul 28, 2022
c31b8f5
Revert "Allow payload to be VALID or ACCEPTED"
paulhauner Jul 28, 2022
6645549
Downgrade geth in EE integration testing
paulhauner Jul 28, 2022
4925fc2
Fix version pinning
paulhauner Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions testing/execution_engine_integration/src/geth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use std::{env, fs::File};
use tempfile::TempDir;
use unused_port::unused_tcp_port;

const GETH_BRANCH: &str = "master";
// const GETH_BRANCH: &str = "master";
const GETH_REPO_URL: &str = "https://github.com/ethereum/go-ethereum";

pub fn build_result(repo_dir: &Path) -> Output {
Expand All @@ -26,8 +26,13 @@ pub fn build(execution_clients_dir: &Path) {
build_utils::clone_repo(execution_clients_dir, GETH_REPO_URL).unwrap();
}

// TODO: this should be set back to the latest release once the following issue is resolved:
//
// - https://github.com/ethereum/go-ethereum/issues/25427
//
// Get the latest tag on the branch
let last_release = build_utils::get_latest_release(&repo_dir, GETH_BRANCH).unwrap();
// let last_release = build_utils::get_latest_release(&repo_dir, GETH_BRANCH).unwrap();
let last_release = "v1.10.20";
build_utils::checkout(&repo_dir, dbg!(&last_release)).unwrap();

// Build geth
Expand Down