-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Builder Specs v0.2.0 #3134
Closed
realbigsean
wants to merge
297
commits into
sigp:unstable
from
realbigsean:pre-bellatrix-blinded-blocks
Closed
Changes from 250 commits
Commits
Show all changes
297 commits
Select commit
Hold shift + click to select a range
f34cace
Fix route
macladson 24cdb2b
Return correct `execution_optimistic` values for api queries by state
macladson 15e5f87
Updated api client functions
macladson 39b645d
Refactor HTTP API tests
macladson e951612
Return 404 when requested root is 0x000..000
macladson 8ecfead
Tidy up
macladson 92c38bc
Avoid recomputing head
macladson 8444e2d
More improvements
macladson a67381d
Use head when computing status for slot
macladson 0faf026
Rebase on unstable
macladson 7240b4d
Add tests
macladson 469e931
Fix conflicts
macladson e3a7033
fix signing
realbigsean 7f7fe9c
Merge branch 'register-validator-api' of https://github.com/realbigse…
realbigsean ca73387
make sure post to validator registration endpoint expects no response
realbigsean a6949bf
allow mock el dead code
realbigsean 62a6cd8
allow mock el dead code
realbigsean a275fb3
wrap the payload header in a bid
realbigsean b1e8e1b
fix query path
realbigsean 0f65967
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…
realbigsean 6669a57
fix bid deserialization
realbigsean 291895d
Update beacon_node/http_api/tests/tests.rs
realbigsean 885819b
Update consensus/types/src/chain_spec.rs
realbigsean edc8dce
Update validator_client/src/preparation_service.rs
realbigsean b20d7fb
Update validator_client/src/preparation_service.rs
realbigsean ca567fd
Update validator_client/src/preparation_service.rs
realbigsean b3ee9b8
actually do bitmask operation in test
realbigsean bdbe795
don't double publish changed keys on epoch boundary
realbigsean 3f66349
only start the registration service if we have the private transactio…
realbigsean ae061f0
publish registrations regardless of how close we are to the merge
realbigsean b759e8d
fix lints, commented out tests for future web3signer addition
realbigsean 054aa0f
supress lint
realbigsean 4553bf9
Merge branch 'register-validator-api' of https://github.com/realbigse…
realbigsean 8a7586e
add timeout to the builder client header endpoint
realbigsean 911ef90
batched validator registration data
realbigsean ebb43e8
add mock builder
realbigsean 7273ea7
Merge branch 'ex-opt-api' of https://github.com/macladson/lighthouse …
realbigsean a7443ce
add builder to api tests
realbigsean 860784f
fix signing in test
realbigsean 210a998
context dep public
realbigsean eefba72
context dep public
realbigsean 7be55a3
logs for debugging
realbigsean ccba070
logs for debugging
realbigsean a52c424
sign builder bids in mock builder
realbigsean d613609
key payload cache by tree hash root not tx root
realbigsean 9657ae8
key payload cache by tree hash root not tx root
realbigsean a82dbec
sign builder bids in mock builder
realbigsean 8f83d2e
sign builder bids in mock builder
realbigsean 3f0f8da
debug logs
realbigsean 16142ec
fix prev randao in mock builder
realbigsean 1677d92
fix randao in mock builder
realbigsean 7f5bd59
json serde mock builder payloads
realbigsean ef78655
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…
realbigsean 3fe4aed
logging updates
realbigsean 337e06e
fix typo
realbigsean c7304f4
improve local testing
realbigsean 90fd5fc
cago fmt, cargo fix, cargo generate-lockfile
realbigsean 5f17141
fix ports in tests
realbigsean d38714b
Validate some fields vs a local payload
realbigsean cd362d2
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…
realbigsean 2a2be0a
fmt and remove reference
realbigsean 39046cc
fix pre-TTD block proposals
realbigsean c25e8ee
fix fix
realbigsean 3c77574
pawan > me
realbigsean ec590c8
start docs
realbigsean 9639d5d
start docs
realbigsean ab6887a
update docker version
realbigsean c5e17ce
lints
realbigsean 83fe495
cargo fmt
realbigsean c41b73e
pin deps
realbigsean ec4676b
Revert "pin deps"
realbigsean 7dc5d41
pin deps
realbigsean d12d03b
Revert "pin deps"
realbigsean ec5f058
Squash previous works
macladson 61ff3b5
Resolve `BeaconChain` compile errors
paulhauner 4fa5be6
Revert `common/eth2` to `unstable`
paulhauner ac01a7e
Fix `http_api` to pass `make lint`
paulhauner 8ade87e
Remove old fork choice functions
paulhauner b00c0db
Fix compile errors in HTTP tests
paulhauner 095ff72
Wrap harness in Arc
paulhauner 211e4cc
Start *horrific* async test refactor
paulhauner 3438ac2
More test fixes
paulhauner 9aa796f
Make tests *finally* compile with async FC
paulhauner 87b4760
Add progress on async block import
paulhauner 3cbffa4
Solve `StoreOp` lifetime problem
paulhauner ac35a43
Reinstate panda banner
paulhauner 2d0f5b9
Partially add `PayloadNotifier`
paulhauner 4597d24
Start Arc-ifying SignedBeaconBlock
paulhauner 0a6b9ae
Arc-ification of networking crate
paulhauner 3e21adb
Fix http_api, `make lint` passes
paulhauner 689f3e6
Refactor exec payload "prepare payload"
paulhauner 59351d2
Make block production async (make lint passing)
paulhauner f9634a6
Fix test compilation errors
paulhauner dc4c7b6
Fix justified checkpoint getter
paulhauner d21536e
Remove deadlock from block import
paulhauner f452bd8
Fix clippy lint
paulhauner 49fce95
Update test for finalized_checkpoint event
paulhauner 11a3eaa
Fix MSRV issue
paulhauner d305f49
Fix failing network tests
paulhauner c3d04bd
Remove HeadSafetyStatus
paulhauner b7bee40
Remove unused error
paulhauner 2e9a8c0
Fix compile errors in beacon chain tests
paulhauner 5be6374
Simplify chain segment processing
paulhauner 1bcf234
Remove some blocking methods
paulhauner 7b7b356
Fix missing `!`
paulhauner 2296643
Fix failing payload_invalidation tests
paulhauner a6a6aae
Fix store test
paulhauner a861777
Remove commented-out code
paulhauner 93864b8
Fix weak subjectivity test
paulhauner ab4e1e8
Move EL update spawning
paulhauner 1faf17a
Fix http_api compile error
paulhauner 52bbd94
Fix compile error in client builder
paulhauner 81d7fc7
Remove genesis alias workaround from EF tests
paulhauner cb8677c
Remove `block_on` from EL
paulhauner 706e385
Remove block_on for blinded blocks in HTTP API
paulhauner 67fd2a4
Disable rayon for fork choice tests
paulhauner de8482d
Simplify getting for active val count
paulhauner 8f24eb1
Make block_on_dangerous respect exit, metrics
paulhauner 1a3070f
Patch and unify status_message
paulhauner 5cda3ee
Move recompute_head into canonical_head
paulhauner 67ca5d7
Remove head_proposer_shuffling_decision_root
paulhauner ccdc74d
Arc-ify BeaconSnapshot
paulhauner be38daa
Spawn new task for after_finalization
paulhauner 90730a7
Provide different state root to db migrator
paulhauner d84550f
Don't log crit when tokio stops block import
paulhauner 0ab1b64
Add back warning for opt head
paulhauner 4badadf
Remove debug formatting for roots
paulhauner 98bed99
Raise gossip block log levels
paulhauner 52cb170
Revert "Remove debug formatting for roots"
paulhauner 6426347
Add weight logging
paulhauner 1603b44
Drop txn_lock
paulhauner 5b2f46a
Compute state root in spawned function
paulhauner 7552f9a
Use state roots iter directly
paulhauner 888b278
Avoid blocking async on canon head lock
paulhauner 161c923
Add fast canonical head
paulhauner 1a4bb67
Remove inconsistent head errors
paulhauner 7f2db8e
Update fast head earlier
paulhauner 1d67297
Ensure FFG checkpoints are consistent with head
paulhauner 4ffdb41
Do timeout lock for beacon state metrics
paulhauner 7199425
Use fast head in http_api
paulhauner 7a44522
Use fast head in notifier
paulhauner 611db3a
Split head and FC locks
paulhauner 79aab62
Get make lint passing
paulhauner 5d4ad4e
Tidy, add comments
paulhauner 65ead81
Tidy comments
paulhauner 7cc0d27
Switch to `Arc<Snapshot>` for `CachedHead`
paulhauner dbde4bf
Expose fork choice locks
paulhauner 08082fb
Tidy
paulhauner 82d8068
Fix test compile errors
paulhauner 858db36
Update Cargo.lock
paulhauner b5043b9
Unify is_optimistic_candidate_block
paulhauner 44a75e7
Fix flipped bool
paulhauner 7c5ea7a
Revert changes to clippy.toml
paulhauner 01e760f
Revert changes to beacon_chain Cargo.toml
paulhauner 459c677
Refactor head accessor methods
paulhauner 2905a9d
Fix broken store test
paulhauner fcbe53f
Fix state_advance_timer TODO
paulhauner 0d8a9d8
Refactor `BeaconChain::best_slot`
paulhauner b5388ae
Fix conflict in `state_advance_timer`
paulhauner 2b1bb42
Use blocking task for FC notifier tx
paulhauner 57d62f1
Update opt sync error message
paulhauner 9d73de2
Remove commented-out code from beacon_processor
paulhauner 343aa37
Add comments to `TaskSpawner`
paulhauner 6de54f1
Reduce duplicate code in sync_methods
paulhauner 934a147
Add comment about val count caches
paulhauner 9ca7d49
Update block_on_dangerous comments
paulhauner 42af8db
Remove phantom block_efficiency file
paulhauner 219327b
Remove parking lot from ef_tests
paulhauner 836ac1c
Use rayon in ef_tests by default
paulhauner 19870a8
Remove erroneous log for opt transition block
paulhauner 6b3b2b7
Tidy
paulhauner 2afe98d
Undo changes to `BeaconChain::import_block`
paulhauner f3ac736
Reduce diff for attestation production
paulhauner de9a72e
Reduce chain segment diff
paulhauner 74f8e0b
Tidy
paulhauner b46088d
Tidy
paulhauner 5f67350
Tidy
paulhauner 733192a
Apply suggestions from code review
paulhauner acc9aac
Use fc write lock for restore
paulhauner 011818f
Address review comments from @realbigsean
paulhauner 6313d63
Apply suggestions from code review
paulhauner b31bc91
Fix bad comment
paulhauner 423c128
Merge branch 'nfd-2' of https://github.com/paulhauner/lighthouse into…
realbigsean f4f1dde
cargo lock
realbigsean a478c92
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…
realbigsean f8ad9ee
remove duplicate dep
realbigsean d0ba45d
fix compile errors after merging
realbigsean 14005f4
fix lints in tests
realbigsean 882b8fa
fix tests and handle 204
realbigsean 3fb17f7
Update HTTP API to include `execution_optimistic` flag in responses
macladson 0b7aaa2
Fix tests and apply suggestions
macladson 5bd566b
Get blinded blocks where possible
macladson 4000c34
Missed one
macladson be1e2e2
Merge branch 'unstable' of https://github.com/sigp/lighthouse into ex…
realbigsean 203cc5e
Merge branch 'ex-opt-unstable' of https://github.com/realbigsean/ligh…
realbigsean 4c32194
fix merge issues
realbigsean c13f69d
lints
realbigsean 7aa2a74
enable validator registration web3signer tests
realbigsean c7f1935
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…
realbigsean 44a88e7
add flag that enables users to override the builder registration time…
ciaranmcveigh5 a5ecf63
Update HTTP API to include `execution_optimistic` flag in responses
macladson 0bda4bb
Fix tests and apply suggestions
macladson 64ed23c
Get blinded blocks where possible
macladson 36704fd
Missed one
macladson ff17b4b
Implement suggestions
macladson af67927
Wrap execution_optimistic in an Option
macladson 1801b19
[builder API] Verify builder signature (#3334)
realbigsean a9d37ef
[builder API] Add/update relay timeouts (#3333)
realbigsean 58b784c
[builder API] Chain health checks before using builder API (#3356)
realbigsean ffd11fa
[builder API] Make gas limit configurable, and add per-validator buil…
realbigsean b6a98a9
Merge branch 'unstable' of https://github.com/sigp/lighthouse into bu…
realbigsean 5762cdb
merge with unstable
realbigsean 0e6ffcd
Undo regression
macladson 3bc29f0
fix tests and block hash check
realbigsean b5a905c
Merge branch 'ex-opt-api' of https://github.com/macladson/lighthouse …
realbigsean 1dfb2ae
lint
realbigsean cdec472
lint
realbigsean a6973bb
Merge branch 'unstable' of https://github.com/sigp/lighthouse into bu…
realbigsean cca72dc
query v1 blinded blocks endpoint as per beacon apis spec
realbigsean bf41da2
fix fee recipient condition
realbigsean ea04ee9
add more builder validation tests
realbigsean 7224220
fix test
realbigsean bebca91
fix cli tests
realbigsean 9a084ba
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…
realbigsean d1ccbe5
fix merge with unstable issues
realbigsean 8163dd5
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…
realbigsean b2607b6
fix merge with unstable
realbigsean 301b1e2
git commit -am "self-review fixes"
realbigsean e36d88e
make sure PATCH to validator def updates initialized validators
realbigsean 6e49531
improve logging, separate blinded and full block request metrics for …
realbigsean 6e1349d
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…
realbigsean a15a0d5
- batch validator registration POST's
realbigsean eb25b5e
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pr…
realbigsean a945498
fix merge with unstable
realbigsean 8fc8b71
Update beacon_node/beacon_chain/src/beacon_chain.rs
realbigsean ae1a500
epochs_since_finalization typo
realbigsean 56d4316
Update beacon_node/beacon_chain/src/chain_config.rs
realbigsean 164e507
Update beacon_node/beacon_chain/src/chain_config.rs
realbigsean 0dd3ff1
Update consensus/types/src/chain_spec.rs
realbigsean 8419a58
Update validator_client/src/validator_store.rs
realbigsean 78a1237
use method during block reconstruction
realbigsean 6093f99
fix line breaks on logs and comments
realbigsean 5ad7632
lockfile update
realbigsean 4c67d7d
fix some more log line lengths
realbigsean 5f6dc08
make sure skips serializing optional fields
realbigsean eda5a5c
update lockfile
realbigsean 84e7f53
docs
realbigsean 755b017
Misc doc suggestions
paulhauner 97dc8b6
update cli help
realbigsean 6eca16a
fix cli whitespace
realbigsean File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
sleepnecessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(don't mind if it stays)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to dig into this again because it's been a while since I added that. I think we do need this.
If you check out the logs in some CI runs on other branches we never get past this log line, even though the
print_logs.shit looks like we should be dumping the whole file.Jul 22 01:12:04.334 INFO Starting from known genesis state service: beaconSo I think what happens is we kick off all the processes and shut them down before they are fully initialized.