Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Shutdown like a Sir #1545

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - Shutdown like a Sir #1545

wants to merge 8 commits into from

Conversation

divagant-martian
Copy link
Collaborator

Issue Addressed

#1494

Proposed Changes

  • Give the TaskExecutor the sender side of a channel that a task can clone to request shutting down
  • The receiver side of this channel is in environment and now we block until ctrl+c or an internal shutdown signal is received
  • The swarm now informs when it has reached 0 listeners
  • The network receives this message and requests the shutdown

@divagant-martian divagant-martian marked this pull request as ready for review August 19, 2020 02:34
AgeManning
AgeManning approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 19, 2020
@divagant-martian
Shutdown like a Sir (#1545)
fdc6e2a 
## Issue Addressed
#1494 

## Proposed Changes
- Give the TaskExecutor the sender side of a channel that a task can clone to request shutting down
- The receiver side of this channel is in environment and now we block until ctrl+c or an internal shutdown signal is received
- The swarm now informs when it has reached 0 listeners
- The network receives this message and requests the shutdown
@bors
Copy link

bors bot commented Aug 19, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Shutdown like a Sir [Merged by Bors] - Shutdown like a Sir Aug 19, 2020
@bors bors bot closed this Aug 19, 2020
@divagant-martian divagant-martian mentioned this pull request Aug 21, 2020
Closed
@divagant-martian divagant-martian deleted the graceful-shutdown branch January 4, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divagant-martian @AgeManning