refactor: extract PartialSignatureMessages::validate() in ssv_types#843
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom Feb 26, 2026
Merged
Conversation
shane-moore
force-pushed
the
refactor/partial-sig-validation
branch
from
a53c604 to
48a6329
Compare
Member
Author
|
@claude, take a look and post response if find anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Splits production changes out of #837 per review feedback.
Proposed Changes
PartialSignatureMessages::validate()method andPartialSignatureMessagesErrortossv_types, mirroring Go'sPartialSignatureMessages.Validate()message_validatorto delegate structural validation (empty, inconsistent signers, zero signer) to the new methodAdditional Info
#837 depends on this PR for its spec tests.