Skip to content

Comments

create signature collector and make processor stateless#76

Merged
jking-aus merged 6 commits intosigp:unstablefrom
dknopik:signature-collector
Jan 10, 2025
Merged

create signature collector and make processor stateless#76
jking-aus merged 6 commits intosigp:unstablefrom
dknopik:signature-collector

Conversation

@dknopik
Copy link
Member

@dknopik dknopik commented Dec 18, 2024

Issue Addressed

Proposed Changes

  • Do not manage any longer running stuff in processor, as that provokes dependency cycles and weird locations for types.
  • Create the signature collector, which... collects signatures. When all signature parts are received, we interpolate it into a full signature to be used for validator services. Currently, the actual cryptography of interpolating is mocked out.

Additional Info

The signature collector is the first component using the processor, which is why the small processor refactor is bundled with the signature collector in this PR.

@dknopik dknopik marked this pull request as ready for review December 18, 2024 16:44
This was referenced Jan 3, 2025
@dknopik dknopik added the ready-for-review This PR is ready to be reviewed label Jan 7, 2025
@dknopik dknopik requested a review from jking-aus January 10, 2025 07:22
@dknopik
Copy link
Member Author

dknopik commented Jan 10, 2025

FYI: if this feels familiar to you, the changes are also included in #77, as this PR (more specifically the processor changes) is a prerequisite for #77. I'll rebase #77 once this is merged.

Copy link
Member

@jking-aus jking-aus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- great work Daniel

@jking-aus jking-aus merged commit 26ecef6 into sigp:unstable Jan 10, 2025
9 checks passed
@dknopik dknopik deleted the signature-collector branch February 5, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants