Skip to content

Guard for mentions suggestions list clipped by bottom edge of window#273

Closed
coxom wants to merge 3 commits intosignavio:masterfrom
hypercharge-code:master
Closed

Guard for mentions suggestions list clipped by bottom edge of window#273
coxom wants to merge 3 commits intosignavio:masterfrom
hypercharge-code:master

Conversation

@coxom
Copy link

@coxom coxom commented Sep 19, 2018

When the mentions popup is near the bottom of the screen it will be moved up so it doesn't get cut.
This correction will only be applied when the property suggestionsPortalHost is not being used.

@DJTB
Copy link

DJTB commented Sep 26, 2018

Anything I can do to help this through?

@nummi
Copy link

nummi commented Mar 8, 2019

I would love to have this feature as well. Thank you for implementing it.

@adityatandon007
Copy link

When will this be merged. Needed this badly in one of my projects. Please add this feature and push it in the next release.

@agneym
Copy link

agneym commented May 15, 2019

Is there any update on this? The PR looks ready.

@jfschwarz
Copy link
Contributor

jfschwarz commented May 16, 2019

The proposed implementation does not look like a robust solution to the problem. While it guards against clipping at the bottom edge it will instead cause clipping at the top edge for long suggestions lists.

There are some other undesired behaviors. For example, when looking at the "Advanced options" example on our demo page, it opens the suggestions overlay to the top even though there would be enough space to open it to the bottom.

If you want to help getting this PR through, please add examples to the demo page and propose a more complete solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants