Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add responseStatus to all resources #936

Merged
merged 4 commits into from
Jan 24, 2025
Merged

feat: add responseStatus to all resources #936

merged 4 commits into from
Jan 24, 2025

Conversation

amertak
Copy link
Contributor

@amertak amertak commented Jan 23, 2025

Description

Adds response.status to all resourceFetch spans.

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Delete options that are not relevant.

  • Manual testing
  • Added integration tests

@amertak amertak requested review from a team as code owners January 23, 2025 17:42
@amertak amertak marked this pull request as draft January 23, 2025 17:42
@amertak amertak marked this pull request as ready for review January 24, 2025 09:44
Joozty
Joozty reviewed Jan 24, 2025
View reviewed changes
@amertak amertak requested a review from Joozty January 24, 2025 10:50
@amertak amertak merged commit e5f4672 into main Jan 24, 2025
10 checks passed
@amertak amertak deleted the feat/resourceFetch branch January 24, 2025 11:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtmalinowski jtmalinowski jtmalinowski approved these changes

@Joozty Joozty Joozty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amertak @jtmalinowski @Joozty