Initial webvitals integration #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmalinowski
reviewed
Dec 3, 2020
src/webvitals.js
Outdated
| export function initWebVitals(provider) { | ||
| const tracer = provider.getTracer('webvitals'); | ||
| // CLS is defined as being sent more than once, easier to just ensure that everything is sent just on the first occurence. | ||
| const reported = {}; |
There was a problem hiding this comment.
you can make this var local to this file, because webvitals should be initiated at most once per page
jtmalinowski
reviewed
Dec 3, 2020
| const value = metric.value; | ||
| const span = tracer.startSpan('webvitals'); | ||
| span.setAttribute(name, value); | ||
| span.end(span.startTime); |
There was a problem hiding this comment.
have we confirmed this with Justin? or are we deciding now it's going to be sent like that
There was a problem hiding this comment.
Excellent point. I'll post on the team channel and seek some input.
There was a problem hiding this comment.
I was going to approve this, but now I'm not sure, I can't seem to find any conclusions in that Slack thread.
There was a problem hiding this comment.
I read it as "looks good enough" but we can wait another day or two for any more objections/discussion to pop up.
jtmalinowski
reviewed
Dec 3, 2020
jtmalinowski
approved these changes
Dec 7, 2020
sfishel-splunk
pushed a commit
to sfishel-splunk/splunk-otel-js-web
that referenced
this pull request
Jun 22, 2022
Initial webvitals integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.